merb

Comments and changes to this ticket

• 

  Nick Dufresne March 10th, 2008 @ 08:22 PM

  • → Title changed from “local variables in partials issue” to “local variable values from method_missing in partials issue”

  I thought about this some more and I realize that the trouble with having local values retrieved through method_missing in template.rb is that we have no way of determining if the local value has been defined or not.

  defined?(foo) returns false because foo is not defined, even if we pass foo in as a local to a partial. The best ways i could think of to get around this issue is to either

  
  # will copy value of foo into foo_local
  <% foo_local = foo rescue nil %> 
  <% foo_local ||= 'default' %>
  
  # check @_merb_partial_locals directly ... obviously a bad idea
  <% foo_local = @_merb_partial_locals.key?(:foo) ? foo : 'default' %>
  
  

  i think the second makes a case for locals hash available to partials. That way we could use locals[:foo] like @_merb_partial_locals. There needs to be a standard way to check for values passed into partials.

• 

  Michael Klishin (antares) May 11th, 2008 @ 03:13 PM

  • → Milestone changed from “” to “0.9.4”

  This ticket is 2 months old. Can you still reproduce the problem 0.9.3 or head? Thank you.

• 

  Nick Dufresne May 12th, 2008 @ 08:06 PM

  I just checked with the latest from git and the problem still exists for the following situation:

  
  <% foo ||= "default" %> 
  <%= foo %>
  
  

  outputs "default" regardless of whether :foo => "bar" or not is passed to partial method.

• 

  Michael Klishin (antares) May 12th, 2008 @ 08:05 PM

  • → State changed from “new” to “open”
• 

  Michael Klishin (antares) May 17th, 2008 @ 03:00 PM

  • → Assigned user changed from “” to “Michael Klishin (antares)”
  • → State changed from “open” to “invalid”

  This is (if you think about it) is a duplicate of #42, so please follow it. Thanks for example, it will be used for testing once decision is made on how locals should work.