#290 [PATCH] Kill shouldn't be immediately triggered on -k or -K opts parse

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:id	tickets sorted by id (creation time)
Combine keywords for powerful searching.
Use advanced searching »

#290 √ resolved

[PATCH] Kill shouldn't be immediately triggered on -k or -K opts parse

Reported by Gabriel Handford | April 30th, 2008 @ 12:49 AM | in 0.9.4

Kill is immediately called when the -k (or -K) opts are encountered. Therefore any arguments passed after the kill won't be handled (like a pidfile).

merb -K 4000 -P /var/run/merb-app.4000.pid doesn't work.

I have a fix at the branch:

It sets an :action value on the options and then in the start method checks it to perform the kill.

I think this makes sense since after arguments are parsed we apply the start (or stop) action.

This in addition to the pidfile patch allows me to manage my merb cluster processes through monit :)

Yehuda Katz April 30th, 2008 @ 09:31 PM
- → Assigned user changed from “Wayne Seguin” to “Yehuda Katz (wycats)”
Yehuda Katz (wycats) April 30th, 2008 @ 09:32 PM
- → Milestone changed from “” to “0.9.4”
- → State changed from “new” to “resolved”