registred_orm? backwards
Reported by Ben Nevile | May 15th, 2008 @ 08:51 PM | in 0.9.4
current registred_orm? (sic) method:
def registred_orm?(orm)
!Merb.generator_scope.include?(:merb_default) && !Merb.generator_scope.include?(orm.to_sym)
end
I believe the second part of that AND statement should not have the exclamation mark in front of it.
Comments and changes to this ticket
-
Michael Klishin (antares) May 15th, 2008 @ 09:00 PM
- → Assigned user changed from “” to “Michael Klishin (antares)”
- → State changed from “new” to “open”
-
Michael Klishin (antares) May 15th, 2008 @ 10:26 PM
- → Milestone changed from “” to “0.9.4”
Ok, it is fixed in my master and will be cherry-picked soon. I'll fix spelling at the same time. But before that I need to finish some router related work, and probably escape doing git cherry-pick.
Works for you? :) Thanks for spotting this issue, specs had been wrong as well, and rare person looks into core extensions for Kernel to spot it.
-
-
Michael Klishin (antares) May 16th, 2008 @ 12:28 AM
- → State changed from “open” to “resolved”
This method has been removed completely after some discussion and changes in Kernel extension file.
-
Michael Klishin (antares) May 16th, 2008 @ 12:29 AM
Note that current dependencies implementation does not satisfy most of active developers and probably will go away pretty soon.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
