backport Rails Inflector changes to merb
Reported by jack dempsey (jackdempsey) | May 28th, 2008 @ 08:05 AM | in 0.9.4
Bringing the changes Wycats made to Rails Inflector back to merb. Couple specs still need decisions on what to do: ~/merb/merb-core inflector_updates$ !spe
spec spec/private/vendor/facets/singular_spec.rb
.........................................................................F..........................................
1)
'Language::English::Inflect#singular singularizes roses => rose' FAILED
expected: "rose",
got: "rosis" (using ==)
./spec/private/vendor/facets/singular_spec.rb:319:
Finished in 0.020671 seconds
116 examples, 1 failure
~/merb/merb-core inflector_updates$ spec spec/private/vendor/facets/plural_spec.rb
.............................................................................................................F..................................................
1)
'Language::English::Inflect#singular pluralizes price => prices' FAILED
expected: "prices",
got: "price" (using ==)
./spec/private/vendor/facets/plural_spec.rb:461:
The first is because of the -osis => -oses rule, and the latter is because 'rice' is used as a special word exemption....which also calls rule and defines things there....so price or anything that ends with 'rice' will be affected.
This is a good thing though because it makes things like merb_child => merb_children and such.
Comments and changes to this ticket
-
Michael Klishin (antares) May 29th, 2008 @ 10:22 AM
- → Milestone changed from to 0.9.4
- → State changed from new to open
-
jack dempsey (jackdempsey) June 18th, 2008 @ 08:36 AM
Adding in the new squashed patch which cleans things up.
-
-
Michael Klishin (antares) June 25th, 2008 @ 12:24 AM
- → State changed from open to resolved
Applied in 322cd6f8.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
