merb-core

Comments and changes to this ticket

• 

  Michael Klishin (antares) June 29th, 2008 @ 01:54 AM

  • → Assigned user changed from “Daniel Neighman (hassox)” to “Yehuda Katz (wycats)”
  • → State changed from “new” to “open”
  • → Milestone changed from “” to “0.9.4”
  • → Tag changed from “controller merb-core views” to “controller major merb-core views”
• 

  Will Prater July 5th, 2008 @ 07:27 PM

  Attached a failing spec for you guys.

  • 0001-Added-view-for-throw_content-spec.patch 2.3 KB
• 

  Will Prater July 16th, 2008 @ 06:48 PM

  Any chance on getting this fixed soon? I've added a failing spec. Thanks

• 

  Michael Klishin (antares) July 16th, 2008 @ 07:39 PM

  • → Assigned user changed from “Yehuda Katz (wycats)” to “Michael Klishin (antares)”
  • → State changed from “open” to “resolved”

  I am not very familiar with rendering stuff but your fix makes spec pass and looks like it should concat, not replace. So I applied it, should be fixed in HEAD.

  If not, blame me for applying broken patches :)

• 

  Will Prater July 16th, 2008 @ 07:45 PM

  Thanks.. this is probably a better fix

  • output.diff 610 Bytes
• 

  Michael Klishin (antares) July 16th, 2008 @ 07:54 PM

  Will,

  Line above assigns [] to content being thrown. Then you ||= it with empty string. Am I missing something? Anyway, this patch blows up about 10 spec examples in -core so I am better leave this as is :)