Route.generate ignores fallback params
Reported by Jarred Holman | July 21st, 2008 @ 05:08 AM | in 0.9.8
Merb::Route.generate() has a misordered statement that prevents the fallback params from being used.
"params[segment] || fallback[segment]" should be the last statement in the block.
The offending code:
value =
if segment.is_a? Symbol
if params.is_a? Hash
params[segment] || fallback[segment]
query_params.delete segment
Comments and changes to this ticket
-
Ben Alpert (spicyj) July 21st, 2008 @ 10:47 PM
- → Tag changed from “” to “fallback merb-core routing”
I believe this patch fixes it.
-
Michael Klishin (antares) August 2nd, 2008 @ 06:35 PM
- → Milestone changed from “” to “0.9.5”
- → State changed from “new” to “open”
Router is being reworked at the moment. Stay tuned.
-
Michael Klishin (antares) August 12th, 2008 @ 08:07 PM
- → Milestone changed from “0.9.5” to “0.9.6”
-
Michael Klishin (antares) September 4th, 2008 @ 11:53 AM
- → Milestone changed from “0.9.6” to “0.9.7”
-
Michael Klishin (antares) September 14th, 2008 @ 02:01 AM
- → Assigned user changed from “” to “Carl Lerche”
- → Milestone changed from “0.9.7” to “0.9.8”
-
Carl Lerche September 21st, 2008 @ 12:53 AM
- → Tag changed from “fallback merb-core routing” to “fallback merb-core routing”
- → State changed from “open” to “resolved”
The new router branch has been merged in. This should not be a problem anymore.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
