raise OK causes logger entry
Reported by lacco | April 16th, 2008 @ 04:31 AM | in 1.0
For actions returning anything it seems that a "raise OK" should be used. But now every "response exception" is logged. All Merb::ControllerExceptions Status exceptions should be catched and not logged.
On the other hand, i'm not sure if raising a status exception is a really nice way (imagine, you are in an activerecord transaction where each exception leads to a rollback). So i request for something like these following statements:
render :nothing, :status => :ok
return :ok
Comments and changes to this ticket
-
Michael Klishin (antares) May 3rd, 2008 @ 08:54 PM
Why do you think Merb::ControllerExceptions should not be logged?
-
lacco May 4th, 2008 @ 04:19 AM
I mean especially Merb::ControllerExceptions Status exceptions, because these exception class doesn't really represent exceptions but are raised just for setting the status and leaving current action.
My logger gets quite full of exceptions which are just from 200 responses, that's why i would prefer an alterantive to raising exceptions, just something with using return or render (see above).
You know what i mean?
-
Michael Klishin (antares) May 11th, 2008 @ 07:47 AM
- → State changed from “new” to “open”
- → Milestone changed from “” to “1.0”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
