The example code in the comments are invalid for error_messages

false

2010-02-01T14:31:14-08:00

23115

32 the-example-code-in-the-comments-are-invalid-for-error_messages_for 0

7435

new The example code in the comments are invalid for error_messages_for

2010-02-01T14:31:19-08:00

23115

Richard Grundy (RichGuk)

http://merb.lighthouseapp.com/projects/7435/tickets/32

In the docblock here: # ==== Examples # <%= error_messages_for :person %> # <%= error_messages_for :person {|errors| "You can has probs nao: #{errors.size} of em!"} # <%= error_messages_for :person, lambda{|error| "<li class='aieeee'>#{error.join(' ')}"} %> # <%= error_messages_for :person, nil, 'bad_mojo' %> These two appear to be invalid? # <%= error_messages_for :person {|errors| "You can has probs nao: #{errors.size} of em!"} # <%= error_messages_for :person, lambda{|error| "<li class='aieeee'>#{error.join(' ')}"} %>

<div><p>In the docblock here:</p> <p># ==== Examples # <%= error_messages_for :person %> # <%= error_messages_for :person {|errors| "You can has probs nao: #{errors.size} of em!"} # <%= error_messages_for :person, lambda{|error| "</p> <ul> <li class="aieeee">#{error.join(' ')}"} %> # <%= error_messages_for :person, nil, 'bad_mojo' %></li> </ul> <p>These two appear to be invalid?</p> <p># <%= error_messages_for :person {|errors| "You can has probs nao: #{errors.size} of em!"} # <%= error_messages_for :person, lambda{|error| "</p> <ul> <li class="aieeee">#{error.join(' ')}"} %></li> </ul></div>

24207

true

2009-01-12T10:07:48-08:00

7341

25 form_for-in-part-generating-weird-html 1

7435

invalid form_for merb-helpers parts form_for in part generating weird HTML

2009-11-13T19:00:15-08:00

16008

Martin Gamsjaeger (snusnu)

drogus (at gmail)

Pavel Kunc (merboutpost)

http://merb.lighthouseapp.com/projects/7435/tickets/25

I've created a CommentsPart and wanted to add action new which basically just render form_for. Here is new.html.erb from views/comments_part/new.html.erb: @@@ ruby <%= form_for(@comment) do %> <%= text_area :body %> <%= submit "Save" %> <% end =%> @@@ Now, when I place this code in app/views/articles/show.html.erb: @@@ ruby <%= part CommentsPart => :new %> @@@ I will got: @@@ html <textarea name="article_comment[body]" id="article_comment_body"> </textarea> <input type="submit" value="Save" name="submit"/> <form method="post" action="/article_comment"> <textarea name="article_comment[body]" id="article_comment_body"></textarea> <input type="submit" value="Save" name="submit"/> </form> @@@ It generates not only form but two duplicates of fields... This code in view @@@ ruby <%= form_for(@comment) do %> <%= text_area :body %> <%= submit "Save" %> <% end =%> @@@ generates: @@@ html <form method="post" action="/nil_class"> <textarea name="nil_class[body]" id="nil_class_body"></textarea> <input type="submit" value="Save" name="submit"/> </form> @@@

<div><p>I've created a CommentsPart and wanted to add action new which basically just render form_for.</p> <p>Here is new.html.erb from views/comments_part/new.html.erb:</p> <pre><code class="ruby"> <%= form_for(@comment) do %> <%= text_area :body %> <%= submit "Save" %> <% end =%> </code></pre> <p>Now, when I place this code in app/views/articles/show.html.erb:</p> <pre><code class="ruby"> <%= part CommentsPart => :new %> </code></pre> <p>I will got:</p> <pre><code class="html"> <textarea name="article_comment[body]" id="article_comment_body"> </textarea> <input type="submit" value="Save" name="submit"/> <form method="post" action="/article_comment"> <textarea name="article_comment[body]" id="article_comment_body"></textarea> <input type="submit" value="Save" name="submit"/> </form> </code></pre> <p>It generates not only form but two duplicates of fields...</p> <p>This code in view</p> <pre><code class="ruby"> <%= form_for(@comment) do %> <%= text_area :body %> <%= submit "Save" %> <% end =%> </code></pre> <p>generates:</p> <pre><code class="html"> <form method="post" action="/nil_class"> <textarea name="nil_class[body]" id="nil_class_body"></textarea> <input type="submit" value="Save" name="submit"/> </form> </code></pre></div>

true

2008-11-15T09:49:57-08:00

12929

9 merb-more-has-merb_datamapper-as-a-dependency 39263

7435

resolved datamapper dependency gem merb-more merb_datamapper merb-more has merb_datamapper as a dependency

2009-09-27T19:25:47-07:00

16008

Martin Gamsjaeger (snusnu)

Ted Han (knowtheory)

http://merb.lighthouseapp.com/projects/7435/tickets/9

As a consequence of the dependency installing merb-more will install merb_datamapper, and its dependencies dm-core, dm-migrations and merb-core (well, that one isn't a problem). Anyway, this is a violation of merb's intended loose coupling.

<div><p>As a consequence of the dependency installing merb-more will install merb_datamapper, and its dependencies dm-core, dm-migrations and merb-core (well, that one isn't a problem).</p> <p>Anyway, this is a violation of merb's intended loose coupling.</p></div>

16008

true

2009-09-10T23:42:07-07:00

34607

31 auto_link-enhancement 1

7435

resolved patch auto_link enhancement

2009-09-27T17:06:44-07:00

16008

Martin Gamsjaeger (snusnu)

Julien Langlois

Martin Gamsjaeger (snusnu)

http://merb.lighthouseapp.com/projects/7435/tickets/31

The auto_link helper has two issues: 1) It loads assets from hard-coded paths, instead of reusing the other asset helpers 2) It does not separate loading CSS from JavaScript (it is prefered that CSS is loaded in the head of a document, while the JavaScript at the end of the body)

<div><p>The auto_link helper has two issues:</p> <p>1) It loads assets from hard-coded paths, instead of reusing the other asset helpers<br> 2) It does not separate loading CSS from JavaScript (it is prefered that CSS is loaded in the head of a document, while the JavaScript at the end of the body)</p></div>

true

2009-08-05T08:39:49-07:00

63248

30 merbsequelmysql-handshake-problem 0

7435

resolved Merb+Sequel+MySQL handshake problem

2009-08-24T05:44:35-07:00

24207

Pavel Kunc (merboutpost)

Cristian.Malinescu

http://merb.lighthouseapp.com/projects/7435/tickets/30

Hi, I try to launch a Merb app where I replaced the default datamapper orm with Sequel, however, I'm stuck at this error: ../gems/mysql-2.7/lib/mysql.so: warning: already initialized constant MysqlError. Cheers, Cris This is a follow up as suggested, http://groups.google.com/group/sequel-talk/browse_thread/thread/57c39428ad8074c2?hl=en Environment: Ubuntu 9, Ruby 1.8.7, Apache2 + Passenger(latest gem), Merb 1.0.12, Sequel(latest gem)

<div><p>Hi,</p> <p>I try to launch a Merb app where I replaced the default datamapper orm with Sequel, however, I'm stuck at this error: ../gems/mysql-2.7/lib/mysql.so: warning: already initialized constant MysqlError.</p> <p>Cheers, Cris</p> <p>This is a follow up as suggested, <a href="http://groups.google.com/group/sequel-talk/browse_thread/thread/57c39428ad8074c2?hl=en"> http://groups.google.com/group/s...</a></p> <p>Environment: Ubuntu 9, Ruby 1.8.7, Apache2 + Passenger(latest gem), Merb 1.0.12, Sequel(latest gem)</p></div>

false

2009-07-19T22:27:19-07:00

63248

29 generated-routerrb-code-incomplete-resulting-in-throwing-exception-no-routes-match-the-request 0

7435

new merb-gen merb-more Generated router.rb code incomplete resulting in throwing *Exception: No routes match the request, /*

2009-08-05T08:43:04-07:00

63248

Cristian.Malinescu

http://merb.lighthouseapp.com/projects/7435/tickets/29

Hello guys, These are the steps for reproducing the problem: 1. Use merb 1.0.12 2. Generate one application with merb-gen 3. In the router.rb generated code I found couple of problems: a) The *.prepare do call is missing the request parameter, so the line should be completed manually like ... Merb::Router.prepare do |r| ... b) Accordingly, next lines of code need manual completion ... r.default_routes ... r.match('/').to(:controller => 'home', :action =>'index') ...

<div><p>Hello guys,</p> <p>These are the steps for reproducing the problem: 1. Use merb 1.0.12 2. Generate one application with merb-gen 3. In the router.rb generated code I found couple of problems: a) The *.prepare do call is missing the request parameter, so the line should be completed manually like</p> <pre> <code> ... Merb::Router.prepare do |r| ... </code> </pre> <p>b) Accordingly, next lines of code need manual completion</p> <pre> <code> ... r.default_routes ... r.match('/').to(:controller => 'home', :action =>'index') ... </code> </pre></div>

false

2009-05-12T15:08:31-07:00

50766

28 abstractassetbundler-might-not-be-thread-safe 106355

7435

new AbstractAssetBundler might not be thread safe?

2009-05-12T15:08:34-07:00

50766

Matt Margolis

http://merb.lighthouseapp.com/projects/7435/tickets/28

This ticket concerns merb-assets bundle functionality. I am working with 1.0.11 When bundling CSS/JS I am finding that under situations with concurrency I end up with inconsistent output from the bundlers. I believe that the locking during file generation is to blame. I believe the issue is File#flock. File#flock is used two times in merb-assets/lib/merb-assets/assets.rb These threads seems to imply that flock is not thread safe. http://groups.google.com/group/ruby-talk-google/browse_thread/thread/1b4036697222e8e1 http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/16818

<div><p>This ticket concerns merb-assets bundle functionality. I am working with 1.0.11</p> <p>When bundling CSS/JS I am finding that under situations with concurrency I end up with inconsistent output from the bundlers. I believe that the locking during file generation is to blame.</p> <p>I believe the issue is File#flock. File#flock is used two times in merb-assets/lib/merb-assets/assets.rb</p> <p>These threads seems to imply that flock is not thread safe.<br></p> <p><a href="http://groups.google.com/group/ruby-talk-google/browse_thread/thread/1b4036697222e8e1"> http://groups.google.com/group/r...</a></p> <p><a href="http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/16818"> http://blade.nagaokaut.ac.jp/cgi...</a></p></div>

21441

true

2009-01-25T14:28:31-08:00

6252

26 new-_call_action-forces-default-repo 19625

7435

resolved datamapper merb_datamapper new _call_action forces :default repo

2009-03-23T07:18:19-07:00

21441

Jonathan Stott (namelessjon)

geemus (Wesley Beary)

Jonathan Stott (namelessjon)

http://merb.lighthouseapp.com/projects/7435/tickets/26

The new wrapping of _call_action with a repository block to provide identity_map forces the usage of default repository on contained calls. The general expectation would be that methods called without a context on a model that has self.default_repository_name set should call the method in the specified repository. This new block wrapper overrides this and calls everything in the default block. As such it would be good to be able to specify which repository to wrap each controller and/or action with. Or at least be able to opt-out of this functionality at the application level. Thanks for putting up with my weird edge cases, wes

<div><p>The new wrapping of _call_action with a repository block to provide identity_map forces the usage of default repository on contained calls.</p> <p>The general expectation would be that methods called without a context on a model that has self.default_repository_name set should call the method in the specified repository. This new block wrapper overrides this and calls everything in the default block.</p> <p>As such it would be good to be able to specify which repository to wrap each controller and/or action with. Or at least be able to opt-out of this functionality at the application level.</p> <p>Thanks for putting up with my weird edge cases, wes</p></div>

2719

false

2009-03-09T21:32:13-07:00

13984

27 slated_user-mixin-encrypt_password-method 90361

7435

new merb-auth slated_user mixin encrypt_password method

2009-03-09T21:45:28-07:00

467

Daniel Neighman

Nicholas Orr

Daniel Neighman (hassox)

http://merb.lighthouseapp.com/projects/7435/tickets/27

change @@@ ruby def encrypt_password return if password.blank? self.salt = Digest::SHA1.hexdigest("--#{Time.now.to_s}--#{Merb::Authentication::Strategies::Basic::Base.login_param}--") if new_record? self.crypted_password = encrypt(password) end @@@ to @@@ ruby def encrypt_password return if password.blank? self.salt = Digest::SHA1.hexdigest("--#{Time.now.to_s}--#{Merb::Authentication::Strategies::Basic::Base.login_param}--") if self.salt.nil? self.crypted_password = encrypt(password) end @@@ This way it works all the time. The issue with using new_record? is it might not be a new record and lack salt. The whole point of that line as I see it is to create salt only if salt doesn't exist - so why not test for the lack of salt :)

<div><p>change</p> <pre><code class="ruby"> def encrypt_password return if password.blank? self.salt = Digest::SHA1.hexdigest("--#{Time.now.to_s}--#{Merb::Authentication::Strategies::Basic::Base.login_param}--") if new_record? self.crypted_password = encrypt(password) end </code></pre> <p>to</p> <pre><code class="ruby"> def encrypt_password return if password.blank? self.salt = Digest::SHA1.hexdigest("--#{Time.now.to_s}--#{Merb::Authentication::Strategies::Basic::Base.login_param}--") if self.salt.nil? self.crypted_password = encrypt(password) end </code></pre> <p>This way it works all the time. The issue with using new_record? is it might not be a new record and lack salt. The whole point of that line as I see it is to create salt only if salt doesn't exist - so why not test for the lack of salt :)</p></div>

false

2008-11-26T20:43:01-08:00

13309

16 selectradio_button-helpers-dont-bind-correctly 41367

7435

new form radio_button radio_group select/radio_button helpers don't bind correctly

2009-01-23T14:34:33-08:00

15000

Lang Riley

Luke Sutton

http://merb.lighthouseapp.com/projects/7435/tickets/16

When using form_for, the bound versions of #select and #radio_button helpers don't select the correct value based on the relevant model property. Instead I have explicitly pass in the selected value.

<div><p>When using form_for, the bound versions of #select and #radio_button helpers don't select the correct value based on the relevant model property. Instead I have explicitly pass in the selected value.</p></div>

false

2009-01-04T13:27:36-08:00

5026

24 autotest-support-for-specrequests 58118

7435

new 1.0 merb-more patch Autotest Support for spec/requests

2009-01-04T13:27:38-08:00

5026

James Herdman

http://merb.lighthouseapp.com/projects/7435/tickets/24

It seems like merb-gen is putting controller specs in specs/requests these days. This patch adds Autotest support for this directory.

<div><p>It seems like merb-gen is putting controller specs in specs/requests these days. This patch adds Autotest support for this directory.</p></div>

false

2008-12-31T14:42:51-08:00

18818

23 generated-autotestmerb_rspecrb-file-is-broken 52530

7435

new generator merb-gen patch Generated autotest/merb_rspec.rb file is broken

2008-12-31T14:42:53-08:00

18818

Stephen Eley

http://merb.lighthouseapp.com/projects/7435/tickets/23

The generated class **Autotest::MerbRspec** inherits poorly from its parent **Autotest** class, overriding several methods (but not their calling methods) and attempting to set instance variables via accessors which are declared in the superclass. This breaks Ruby's inheritance rules, and the result is that **all_good** is never true. Basic looping behavior seems to work anyway, but the **get_to_green** method never finishes. I'm too much of a newbie to write a proper spec to prove that a loop in Autotest fails to terminate. (Not to mention I spent all afternoon chasing this bug down and it burned me out.) I detected this issue because I'm running Cucumber with David Leal's [merb-cucumber](http://github.com/david/merb_cucumber/tree/master) plug-in, which inherits from **Autotest::MerbRspec**, and it wasn't displaying the right behavior when it called _super_ in its own **get_to_green**. I know this is discouraged in your contributor guidelines, but I'm attaching a patch (actually a rewritten **merb_rspec.rb** file) in spite of not having a spec. The simplest solution is to inherit from **Autotest::Rspec** instead of **Autotest** and not override any methods except for initialization. I'm not sure why they were overridden anyway, since they seemed to do the same thing and have no dramatic efficiency improvements. This new autotest file is a lot simpler and makes better use of the inherited behavior.

<div><p>The generated class <strong>Autotest::MerbRspec</strong> inherits poorly from its parent <strong>Autotest</strong> class, overriding several methods (but not their calling methods) and attempting to set instance variables via accessors which are declared in the superclass. This breaks Ruby's inheritance rules, and the result is that <strong>all_good</strong> is never true. Basic looping behavior seems to work anyway, but the <strong>get_to_green</strong> method never finishes.</p> <p>I'm too much of a newbie to write a proper spec to prove that a loop in Autotest fails to terminate. (Not to mention I spent all afternoon chasing this bug down and it burned me out.) I detected this issue because I'm running Cucumber with David Leal's <a href="http://github.com/david/merb_cucumber/tree/master">merb-cucumber</a> plug-in, which inherits from <strong>Autotest::MerbRspec</strong>, and it wasn't displaying the right behavior when it called <em>super</em> in its own <strong>get_to_green</strong>.</p> <p>I know this is discouraged in your contributor guidelines, but I'm attaching a patch (actually a rewritten <strong>merb_rspec.rb</strong> file) in spite of not having a spec. The simplest solution is to inherit from <strong>Autotest::Rspec</strong> instead of <strong>Autotest</strong> and not override any methods except for initialization. I'm not sure why they were overridden anyway, since they seemed to do the same thing and have no dramatic efficiency improvements. This new autotest file is a lot simpler and makes better use of the inherited behavior.</p></div>

false

2008-12-30T20:46:46-08:00

14031

22 escape_xml-in-formbuilderoptions-breaks-selected-matching-for-integers 50309

7435

new merb-helpers escape_xml in Form::Builder.options breaks :selected matching for integers

2008-12-30T20:48:15-08:00

14031

bentlegen

http://merb.lighthouseapp.com/projects/7435/tickets/22

The escape_xml call in merb-helpers/form/builder.rb L251 (http://github.com/wycats/merb/tree/active/merb-helpers/lib/merb-helpers/form/builder.rb#L251) forces each :collection element value to a string. This takes place before the :collection is matched against the :selected param, which could still be an integer. The result is that the following call: options( [1,2,3,4,5].map{|i| [i]}, # collection nil, # text_method nil, # value_method 3 # selected ) Doesn't match the value 3. You need to do the following: options( [1,2,3,4,5].map{|i| [i]}, nil, nil, "3" ) I think this behaviour was introduced here: http://github.com/wycats/merb/commit/168ac57eeecc1f416179594e0f92a5ce7c62a098#L2L247

<div><p>The escape_xml call in merb-helpers/form/builder.rb L251 (<a href="http://github.com/wycats/merb/tree/active/merb-helpers/lib/merb-helpers/form/builder.rb#L251">http://github.com/wycats/merb/tr...</a>) forces each :collection element value to a string. This takes place before the :collection is matched against the :selected param, which could still be an integer. The result is that the following call:</p> <p>options( [1,2,3,4,5].map{|i| [i]}, # collection nil, # text_method nil, # value_method 3 # selected )</p> <p>Doesn't match the value 3. You need to do the following:</p> <p>options( [1,2,3,4,5].map{|i| [i]}, nil, nil, "3" )</p> <p>I think this behaviour was introduced here:</p> <p><a href="http://github.com/wycats/merb/commit/168ac57eeecc1f416179594e0f92a5ce7c62a098#L2L247"> http://github.com/wycats/merb/co...</a></p></div>

false

2008-12-28T16:46:22-08:00

13984

21 transformer-typo-on-the-au-unit 46197

7435

new merb-helpers Transformer: Typo on the AU unit

2008-12-28T22:53:31-08:00

13984

Nicholas Orr

http://merb.lighthouseapp.com/projects/7435/tickets/21

Nice and simple. Line 39 of merb-helpers/core_ext/numeric.rb needs to be changed from @@@ruby :unit => '$;', @@@ to @@@ruby :unit => '$', @@@ :)

<div><p>Nice and simple.</p> <p>Line 39 of merb-helpers/core_ext/numeric.rb</p> <p>needs to be changed from</p> <p>@@@ruby :unit => '$;',</p> <pre><code> to @@@ruby :unit => '$', </code></pre> <p>:)</p></div>

true

2008-12-21T09:01:36-08:00

13312

20 radio-button-helper-checked 45403

7435

invalid merb-helpers radio button helper :checked

2008-12-22T16:19:58-08:00

10354

Michael Klishin (antares)

Jon Hancock

http://merb.lighthouseapp.com/projects/7435/tickets/20

The :checked hash param of radio_button helper needs to check if :checked is true. If it is anything but true, the attribute should not be merged into the html attribs as radio buttons are goofy in html in that if the checked param has _any_ value it will be on. It seems this check needs to go in builder.rb bound_radio_button

<div><p>The :checked hash param of radio_button helper needs to check if :checked is true. If it is anything but true, the attribute should not be merged into the html attribs as radio buttons are goofy in html in that if the checked param has <em>any</em> value it will be on.</p> <p>It seems this check needs to go in builder.rb bound_radio_button</p></div>

false

2008-12-20T23:41:49-08:00

13265

19 patch-for-merb-helpers-separate-error-messages-for-the-same-field 45358

7435

new [Patch] For merb-helpers, separate error messages for the same field

2008-12-21T00:10:45-08:00

13265

Emmanuel Surleau (Mercurial Alchemist)

http://merb.lighthouseapp.com/projects/7435/tickets/19

Currently, error messages (created with error_messages_for) are formatted in a list, with one li tag for each field. However, for AR-like models, errors for the same fields are joined with a space. This gives such interesting error messages as: Name must not be blank Name must be between 1 and 255 characters long The attached patch (for 1.0.x) corrects this behaviour, by creating an li item for each error. You will also find a failing spec attached.

<div><p>Currently, error messages (created with error_messages_for) are formatted in a list, with one li tag for each field. However, for AR-like models, errors for the same fields are joined with a space. This gives such interesting error messages as:</p> <p>Name must not be blank Name must be between 1 and 255 characters long</p> <p>The attached patch (for 1.0.x) corrects this behaviour, by creating an li item for each error. You will also find a failing spec attached.</p></div>

false

2008-12-18T02:50:12-08:00

13091

18 merb-cache-fails-on-second-attempt-to-register-a-store 44935

7435

new merb-cache merb_activerecord merb-cache fails on second attempt to register a store

2008-12-20T15:43:09-08:00

13091

Vince Nibler

http://merb.lighthouseapp.com/projects/7435/tickets/18

ActiveRecord migrations fail if merb-cache is defined for your environment. - the merb app Rakefile loads the merb environment. Line 24: Merb.start_environment(:environment => init_env, :adapter => 'runner') - the merb activerecord migration task attempts to load the environment again. In lib/active_record/merbtasks.rb line 3: task :merb_start do Merb.start :adapter => 'runner', :environment => ENV['MERB_ENV'] || 'development', :log_file => Merb::Config[:log_file] end - merb-cache fails: file_store store already setup - the migrations are not run.

<div><p>ActiveRecord migrations fail if merb-cache is defined for your environment.</p> <ul> <li>the merb app Rakefile loads the merb environment. Line 24:</li> </ul> <p>Merb.start_environment(:environment => init_env, :adapter => 'runner')</p> <ul> <li>the merb activerecord migration task attempts to load the environment again. In lib/active_record/merbtasks.rb line 3:</li> </ul> <p>task :merb_start do</p> <pre> <code>Merb.start :adapter => 'runner', :environment => ENV['MERB_ENV'] || 'development', :log_file => Merb::Config[:log_file] </code> </pre> <p>end</p> <ul> <li>merb-cache fails:</li> </ul> <p>file_store store already setup</p> <ul> <li>the migrations are not run.</li> </ul></div>

false

2008-12-09T01:48:02-08:00

9151

17 merb-mailer-doesnt-supply-useful-helpers-in-the-merbmailcontroller 43172

7435

new merb-mailer merb-mailer doesn't supply useful helpers in the Merb::MailController

2008-12-09T01:48:06-08:00

9151

Dirkjan Bussink

http://merb.lighthouseapp.com/projects/7435/tickets/17

When generating HTML emails, it would be useful to have some of the helpers available that are available in regular controllers, such as h(). I want to prevent xss attacks in my emails :).

<div><p>When generating HTML emails, it would be useful to have some of the helpers available that are available in regular controllers, such as h(). I want to prevent xss attacks in my emails :).</p></div>

false

2008-11-14T20:42:22-08:00

25393

8 merb-gen-resource-p-changes-configrouterrb 39239

7435

new 1.0 generator merb-gen noncritical patch resource "merb-gen resource -p" changes config/router.rb

2008-12-02T23:27:31-08:00

10280

Carl Porth

Dale Campbell

http://merb.lighthouseapp.com/projects/7435/tickets/8

When using "merb-gen resource -p" the generator changes the config/router.rb file, adding a "resources :model_name" line. No other files are edited/created. --- $ merb-gen resource -p article Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Generating with resource generator (just pretending): Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb [ADDED] spec/models/article_spec.rb [ADDED] app/models/article.rb [ADDED] spec/requests/articles_spec.rb [ADDED] app/controllers/articles.rb [ADDED] app/views/articles/index.html.erb [ADDED] app/views/articles/show.html.erb [ADDED] app/views/articles/edit.html.erb [ADDED] app/views/articles/new.html.erb [ADDED] app/helpers/articles_helper.rb resources :articles route added to config/router.rb

<div><p>When using "merb-gen resource -p" the generator changes the config/router.rb file, adding a "resources :model_name" line. No other files are edited/created.</p> <hr> <p>$ merb-gen resource -p article Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Generating with resource generator (just pretending): Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb Loading init file from /path/to/some_app/config/init.rb Loading /path/to/some_app/config/environments/development.rb</p> <pre> <code> [ADDED] spec/models/article_spec.rb [ADDED] app/models/article.rb [ADDED] spec/requests/articles_spec.rb [ADDED] app/controllers/articles.rb [ADDED] app/views/articles/index.html.erb [ADDED] app/views/articles/show.html.erb [ADDED] app/views/articles/edit.html.erb [ADDED] app/views/articles/new.html.erb [ADDED] app/helpers/articles_helper.rb </code> </pre> <p>resources :articles route added to config/router.rb</p></div>

14694

true

2008-11-25T12:44:43-08:00

14981

15 questions-about-merb-slices 42462

7435

hold merb-slices Questions about merb-slices

2008-11-25T13:06:14-08:00

14694

Fabien Franzen (loob2)

Tim Carey-Smith

Fabien Franzen (loob2)

http://merb.lighthouseapp.com/projects/7435/tickets/15

I am building a slice which doesn't have any routes. It just provides shared models for other applications. I was confused about the usage of the #init and #activate methods. The #activate method is only run if the slice is routed. Perhaps there needs to be a better description of what these methods do and when they are run. Would it be better to have a more explicit way of activating slices external to the router? That way I could say Merb::Slices.enable(:my_slice_with_models). What is the idea behind the Merb::Plugins.config[:merb_slices][:search_path] configuration? In the generated spec_helper.rb, it uses the path to the library file. http://github.com/wycats/merb/tree/master/merb-slices%2Flib%2Fgenerators%2Ftemplates%2Ffull%2Fspec%2Fspec_helper.rb#L8

<div><p>I am building a slice which doesn't have any routes. It just provides shared models for other applications.</p> <p>I was confused about the usage of the #init and #activate methods. The #activate method is only run if the slice is routed.</p> <p>Perhaps there needs to be a better description of what these methods do and when they are run.</p> <p>Would it be better to have a more explicit way of activating slices external to the router? That way I could say Merb::Slices.enable(:my_slice_with_models).</p> <p>What is the idea behind the Merb::Plugins.config[:merb_slices][:search_path] configuration? In the generated spec_helper.rb, it uses the path to the library file.</p> <p><a href="http://github.com/wycats/merb/tree/master/merb-slices%2Flib%2Fgenerators%2Ftemplates%2Ffull%2Fspec%2Fspec_helper.rb#L8"> http://github.com/wycats/merb/tr...</a></p></div>

14694

false

2008-11-25T11:54:25-08:00

14981

14 scary-rescue-in-merb-slices 42461

7435

new merb-slices Scary rescue in merb-slices

2008-11-25T11:54:53-08:00

14981

Tim Carey-Smith

Fabien Franzen (loob2)

http://merb.lighthouseapp.com/projects/7435/tickets/14

If I have an error in my init or activate, I would like to know about it. http://github.com/wycats/merb/tree/master/merb-slices%2Flib%2Fmerb-slices%2Fmodule.rb#L123

<div><p>If I have an error in my init or activate, I would like to know about it.</p> <p><a href="http://github.com/wycats/merb/tree/master/merb-slices%2Flib%2Fmerb-slices%2Fmodule.rb#L123"> http://github.com/wycats/merb/tr...</a></p></div>

2719

true

2008-10-31T02:20:28-07:00

23115

2 improvements-to-merb-auths-openid-strategy 35011

7435

resolved merb-auth openid Improvements to merb-auth's OpenID strategy

2008-11-21T16:03:58-08:00

2719

Daniel Neighman (hassox)

Richard Grundy (RichGuk)

Daniel Neighman (hassox)

http://merb.lighthouseapp.com/projects/7435/tickets/2

Attached are some patches: 1st - Extracted the redirect_to location into a method so this can be overwritten. 2nd Added a method to allow for more customization of the OpenID request, the method is to be overwritten.

<div><p>Attached are some patches:</p> <p>1st - Extracted the redirect_to location into a method so this can be overwritten.</p> <p>2nd Added a method to allow for more customization of the OpenID request, the method is to be overwritten.</p></div>

2719

false

2008-11-21T15:47:04-08:00

10329

13 merb-auth-pass-response-headers-through-to-the-application 35013

7435

new merb-auth patch merb-auth: Pass response headers through to the application

2008-11-21T15:47:08-08:00

10329

Paul Sadauskas (Rando)

Daniel Neighman (hassox)

http://merb.lighthouseapp.com/projects/7435/tickets/13

In http digest auth, it is possible and advantageous to set an 'Authentication-Info' header with details that can be used by the client to pre-authorize for the next request. Currently, any headers that get set during a strategy are 'forgotten', and not available in the main merb application, and consequently doesn't make it back to the client. The patch makes that possible.

<div><p>In http digest auth, it is possible and advantageous to set an 'Authentication-Info' header with details that can be used by the client to pre-authorize for the next request. Currently, any headers that get set during a strategy are 'forgotten', and not available in the main merb application, and consequently doesn't make it back to the client. The patch makes that possible.</p></div>

true

2008-11-11T08:24:36-08:00

10618

7 fatal-the-file-dm-core-was-not-found 38470

7435

invalid critical dm-core jruby merb-gen FATAL: The file dm-core was not found

2008-11-20T22:57:03-08:00

10354

Michael Klishin (antares)

Jaroslaw Zabiello

http://merb.lighthouseapp.com/projects/7435/tickets/7

Strange. Datamapper gems were installed successfully under JRuby (I use fresh edge version rev8042). Merb project was also created fine. But I cannot create controller because Merb raises exception "FATAL: The file dm-core was not found". It but it make no sense, because I have that gem and dependency. http://pastie.org/312339

<div><p>Strange. Datamapper gems were installed successfully under JRuby (I use fresh edge version rev8042). Merb project was also created fine. But I cannot create controller because Merb raises exception "FATAL: The file dm-core was not found". It but it make no sense, because I have that gem and dependency.</p> <p><a href="http://pastie.org/312339">http://pastie.org/312339</a></p></div>

2719

false

2008-11-20T16:59:29-08:00

15574

12 dodgy-merb-auth-callbacks-in-password-slice 35012

7435

new merb-auth dodgy merb-auth callbacks in password slice

2008-11-20T17:28:01-08:00

2719

Daniel Neighman (hassox)

Corey Donohoe

Daniel Neighman (hassox)

http://merb.lighthouseapp.com/projects/7435/tickets/12

http://skitch.com/atmos/hey7/merb-auth-merb-auth-slice-password-app-controllers-sessions.rb-at-master-from-wycats-s-merb-github

<div><p><a href="http://skitch.com/atmos/hey7/merb-auth-merb-auth-slice-password-app-controllers-sessions.rb-at-master-from-wycats-s-merb-github"> http://skitch.com/atmos/hey7/mer...</a></p></div>

false

2008-11-19T04:27:19-08:00

13283

10 patch-enhanced-to-support-index_by-option-for-form_for-fields_for-and-fieldset_for 40043

7435

new merb-helpers [PATCH] Enhanced to support :index_by option for form_for(), fields_for(), and fieldset_for().

2008-11-19T18:27:56-08:00

13283

kwatch

http://merb.lighthouseapp.com/projects/7435/tickets/10

A patch to enhance form_for(), fields_for(), and fieldset_for() to take :index_by option which helps you to generate same controls for several model objects. For example: @@@ <% @students.each do |student| %> <% id = student.id %> <p> <%= text_field :name => "student[#{id}][name]", :value => student.name, :label => 'Name' %> <%= text_field :mail => "student[#{id}][mail]", :value => student.mail, :label => 'Mail' %> </p> <% end %> @@@ ...will be: @@@ <% @students.each do |student| %> <%= fields_for student, :index_by => :id do %> <p> <%= text_field :name, :label => 'Name' %> <%= text_field :mail, :label => 'Mail' %> </p> <% end =%> <% end %> @@@ ...if you apply the patch. The latter is more compact and readable than the former. Both generate the same HTML such as: @@@ <p> <label for="student_name_101">Name</label> <input type="text" name="student[101][name]" id="student_name_101" value="Foo" /> <label for="student_mail_101">Mail</label> <input type="text" name="student[101][mail]" id="student_mail_101" value="foo@mail.com" /> </p> <p> <label for="student_name_102">Name</label> <input type="text" name="student[102][name]" id="student_name_102" value="Bar" /> <label for="student_mail_102">Mail</label> <input type="text" name="student[102][mail]" id="student_mail_102" value="bar@mail.com" /> </p> @@@ This way makes for controller action to handle several model objects very easy. @@@ def update params[:student].each do |id, values| student = Student.get(id) or NotFound student.update_attributes(values) ... end end @@@

<div><p>A patch to enhance form_for(), fields_for(), and fieldset_for() to take :index_by option which helps you to generate same controls for several model objects.</p> <p>For example:</p> <pre><code> <% @students.each do |student| %> <% id = student.id %> <p> <%= text_field :name => "student[#{id}][name]", :value => student.name, :label => 'Name' %> <%= text_field :mail => "student[#{id}][mail]", :value => student.mail, :label => 'Mail' %> </p> <% end %> </code></pre> <p>...will be:</p> <pre><code> <% @students.each do |student| %> <%= fields_for student, :index_by => :id do %> <p> <%= text_field :name, :label => 'Name' %> <%= text_field :mail, :label => 'Mail' %> </p> <% end =%> <% end %> </code></pre> <p>...if you apply the patch. The latter is more compact and readable than the former.</p> <p>Both generate the same HTML such as:</p> <pre><code> <p> <label for="student_name_101">Name</label> <input type="text" name="student[101][name]" id="student_name_101" value="Foo" /> <label for="student_mail_101">Mail</label> <input type="text" name="student[101][mail]" id="student_mail_101" value="foo@mail.com" /> </p> <p> <label for="student_name_102">Name</label> <input type="text" name="student[102][name]" id="student_name_102" value="Bar" /> <label for="student_mail_102">Mail</label> <input type="text" name="student[102][mail]" id="student_mail_102" value="bar@mail.com" /> </p> </code></pre> <p>This way makes for controller action to handle several model objects very easy.</p> <pre><code> def update params[:student].each do |id, values| student = Student.get(id) or NotFound student.update_attributes(values) ... end end </code></pre></div>

false

2008-11-19T18:25:52-08:00

13283

11 patch-refactor-bound_text_area-to-use-control_name-in-formbuilderrb 40206

7435

new merb-helpers [PATCH] Refactor bound_text_area() to use control_name() in 'form/builder.rb'.

2008-11-19T18:25:55-08:00

13283

kwatch

http://merb.lighthouseapp.com/projects/7435/tickets/11

bound_text_area() in 'form/builder.rb' should use 'control_name(method)' instead of '"#{@name}[#{method}]"'. @@@ diff --git a/merb-helpers/lib/merb-helpers/form/builder.rb b/merb-helpers/lib/me rb-helpers/form/builder.rb index 81dfa74..c962775 100644 --- a/merb-helpers/lib/merb-helpers/form/builder.rb +++ b/merb-helpers/lib/merb-helpers/form/builder.rb @@ -99,7 +99,8 @@ module Merb::Helpers::Form::Builder end def bound_text_area(method, attrs = {}) - name = "#{@name}[#{method}]" + #name = "#{@name}[#{method}]" + name = control_name(method) update_bound_controls(method, attrs, "text_area") unbound_text_area(control_value(method), {:name => name}.merge(attrs)) end @@@

<div><p>bound_text_area() in 'form/builder.rb' should use 'control_name(method)' instead of '"#{@name}[#{method}]"'.</p> <pre><code> diff --git a/merb-helpers/lib/merb-helpers/form/builder.rb b/merb-helpers/lib/me rb-helpers/form/builder.rb index 81dfa74..c962775 100644 --- a/merb-helpers/lib/merb-helpers/form/builder.rb +++ b/merb-helpers/lib/merb-helpers/form/builder.rb @@ -99,7 +99,8 @@ module Merb::Helpers::Form::Builder end def bound_text_area(method, attrs = {}) - name = "#{@name}[#{method}]" + #name = "#{@name}[#{method}]" + name = control_name(method) update_bound_controls(method, attrs, "text_area") unbound_text_area(control_value(method), {:name => name}.merge(attrs)) end </code></pre></div>

false

2008-11-10T16:04:58-08:00

16843

6 form_for-does-not-pluralize-route-name 38356

7435

new form_for does not pluralize route name

2008-11-10T21:14:40-08:00

24705

Ben Alpert (spicyj)

Kyle Drake

http://merb.lighthouseapp.com/projects/7435/tickets/6

resources :people + class People < Application def new @person = Person.new render end end + <%= form_for @person do %> <%= text_field :name %> <%= submit 'Go!' %> <% end =%> = <form method="post" action="/person"> <input type="text" class="text" value="" name="person[name]" id="person_name"/> <input type="submit" value="Go!" name="submit"/> </form> It should be action="/people".

<div><p>resources :people</p> <p>+</p> <p>class People < Application</p> <p>def new</p> <pre> <code>@person = Person.new render </code> </pre> <p>end</p> <p>end</p> <p>+</p> <p><%= form_for @person do %> <%= text_field :name %> <%= submit 'Go!' %> <% end =%></p> <p>=</p> <p>It should be action="/people".</p></div>

12714

false

2008-11-06T12:22:54-08:00

15495

5 wrong-constant-name-testmain 34672

7435

new 0.9.13 constant merb-action-args merb-slices wrong constant name Test:Main

2008-11-06T12:24:02-08:00

15495

uipoet

Yehuda Katz (wycats)

http://merb.lighthouseapp.com/projects/7435/tickets/5

With a clean installation of merb 0.9.13 stack and the default generated merb-slice called "test" depended and routed, start up the merb host app and navigate to the default routed url "localhost:4000/test". Here's what you get: ~ Connecting to database... ~ Loaded slice 'MerbAuthSlicePassword' ... ~ Loaded slice 'Test' ... ~ Parent pid: 3454 ~ Compiling routes... ~ Activating slice 'MerbAuthSlicePassword' ... ~ Activating slice 'Test' ... merb : worker (port 80) ~ Starting Thin at port 80 merb : worker (port 80) ~ Using Thin adapter on host 0.0.0.0 and port 80. merb : worker (port 80) ~ Successfully bound to port 80 merb : worker (port 80) ~ Started request handling: Thu Nov 06 12:09:53 -0800 2008 merb : worker (port 80) ~ Routed to: {"action"=>"index", "controller"=>"test/main"} merb : worker (port 80) ~ Params: {"action"=>"index", "controller"=>"test/main"} merb : worker (port 80) ~ wrong constant name Test::Main - (NameError) /Library/Ruby/Gems/1.8/gems/merb-action-args-0.9.13/lib/merb-action-args/get_args.rb:86:in `const_get'

<div><p>With a clean installation of merb 0.9.13 stack and the default generated merb-slice called "test" depended and routed, start up the merb host app and navigate to the default routed url "localhost:4000/test".</p> <p>Here's what you get:</p> <p>~ Connecting to database... ~ Loaded slice 'MerbAuthSlicePassword' ... ~ Loaded slice 'Test' ... ~ Parent pid: 3454 ~ Compiling routes... ~ Activating slice 'MerbAuthSlicePassword' ... ~ Activating slice 'Test' ... merb : worker (port 80) ~ Starting Thin at port 80 merb : worker (port 80) ~ Using Thin adapter on host 0.0.0.0 and port 80. merb : worker (port 80) ~ Successfully bound to port 80 merb : worker (port 80) ~ Started request handling: Thu Nov 06 12:09:53 -0800 2008 merb : worker (port 80) ~ Routed to: {"action"=>"index", "controller"=>"test/main"} merb : worker (port 80) ~ Params: {"action"=>"index", "controller"=>"test/main"} merb : worker (port 80) ~ wrong constant name Test::Main - (NameError) /Library/Ruby/Gems/1.8/gems/merb-action-args-0.9.13/lib/merb-action-args/get_args.rb:86:in <code>const_get'</code></p></div>

12714

false

2008-11-04T22:17:22-08:00

17921

4 additional-cache-store-mintcache-for-merb-cache 34671

7435

new cache merb-cache patch store Additional cache store "mintcache" for merb-cache

2008-11-04T22:19:23-08:00

17921

Ben Schwarz

Yehuda Katz (wycats)

http://merb.lighthouseapp.com/projects/7435/tickets/4

Added a new cache store that was burned while benburkert was doing his hack over the original repo hassox and I started. Other than this there is a change to the run_later request hash that merb-cache sends, only in regard to setting a “merb” user agent.

<div><p>Added a new cache store that was burned while benburkert was doing his hack over the original repo hassox and I started.</p> <p>Other than this there is a change to the run_later request hash that merb-cache sends, only in regard to setting a “merb” user agent.</p></div>