merb-more rake files need cleaning up
Reported by Tim Dysinger | May 3rd, 2008 @ 11:50 PM | in 1.0 (Nearish Future)
[5:27pm] dysinger: The rake files in merb-more are messy. Is there a plan to clean them up ?
[5:27pm] dysinger: rake bundle has been failing for a week or more - since I started trying it.
[5:30pm] ivey: dysinger: yes they are, and yes there is
[5:30pm] dysinger: ok I was just about to put up a lighthouse ticket
[5:31pm] dysinger: because there aren't any open ones on that subject afaik
[5:32pm] dysinger: it would seem to me that ALL those rakefiles could be refactored into a common include
[5:32pm] dysinger: they are almost all identical - except they were are generated and then hand edited each by a different developer
[5:33pm] ivey: indeed
[5:33pm] brentc4m joined the chat room.
[5:33pm] brentc4m was granted voice by ChanServ.
[5:33pm] ivey: dysinger: feel like cleaning it up?
[5:33pm] ivey: i'd LOVE to see a patch for it...we really need 'rake specs' at the top level of -more to work
[5:33pm] dysinger: sure let me poke around and see if there are any related tickets.
[5:36pm] piclez__ joined the chat room.
[5:36pm] piclez__ was granted voice by ChanServ.
[5:37pm] dysinger: So ivey - I don't want to do this solo and then have the ticket scrutinized that it isn't in alignment with the project
[5:37pm] dysinger: Let's talk about it for a second
[5:37pm] ivey: sure
[5:37pm] dysinger: I was envisioning a skeletal top level rakefile
[5:37pm] ivey: although we don't do that very often
[5:37pm] dysinger: and then small little rake files in each sub-project
[5:38pm] dysinger: with an include to pull in a common rakefile
[5:38pm] ivey: here are what i see as Important Things:
[5:38pm] dysinger: so that you can reuse
[5:38pm] ivey: 1) merb-more 'rake specs' runs all the specs
[5:38pm] dysinger: and it's uniform
[5:38pm] ivey: 2) each sub-project 'rake specs' runs that projects' specs
[5:38pm] afrench joined the chat room.
[5:38pm] afrench was granted voice by ChanServ.
[5:38pm] ivey: 3) same for 'rake package' eventually
[5:38pm] dysinger: Does it have to work so that you can have merb-freezer by itself for example ?
[5:39pm] dysinger: without it being as a sub-folder ?
[5:39pm] ivey: yeah i want to be able to cd to merb-freezer and run rake specs
[5:39pm] dysinger: no I mean will it ever be the case that someone just has a tar for example of merb-freezer and nothing else
[5:39pm] ivey: hmm
[5:40pm] dysinger: or can I count on it always being in the git project format that it's in now.
[5:40pm] dysinger: I was thinking of including a common rake file
[5:40pm] ivey: does anyone ever run specs out of installed gem dirs?
[5:40pm] dysinger: but that doesn't work so well if you just want to walk off with one sub-folder
[5:40pm] afrench left the chat room. (Client Quit)
[5:40pm] dysinger: I don't
[5:40pm] dysinger: I don't even see the point of including specs in the installed gem
[5:40pm] ivey: I'm fine with "if you want to pull merb-* out of merb-more and run it separately, you also have to pull file X from -more itself"
[5:41pm] ivey: so maybe the sub-Rakefiles can check for that file at . and ..
[5:41pm] dysinger: it would just be the top level rake common file
[5:41pm] ivey: so they can just copy the common file into -freezer and it works
[5:41pm] dysinger: ok
[5:41pm] ivey: but in the non-stupid case it uses the shared one
[5:42pm] dysinger: ok so I'll make up a ticket
[5:42pm] dysinger: and paste in these notes ^
[5:43pm] ivey: cool
Comments and changes to this ticket
-
Michael Klishin (antares) May 11th, 2008 @ 07:47 AM
- → Milestone changed from to 1.0 (Nearish Future)
- → State changed from new to open
-

Matt Aimonetti May 28th, 2008 @ 03:06 AM
- → State changed from open to resolved
- → Assigned user changed from to Fabien Franzen (loob2)
re factored by loob2 today.
rake bundle does work now and we have a new shared rake helper file in merb-core now.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
