[PULL] error collection warning: multiple values for a block parameter (2 for 1)
Reported by Ryan Felton | April 29th, 2008 @ 10:20 PM
Within merb_helpers/lib/merb_helpers/form_helpers.rb on line 83 has the following warning when running a test against active record validation:
/opt/local/lib/ruby/gems/1.8/gems/merb_helpers-0.9.2/lib/merb_helpers/form_helpers.rb:83: warning: multiple values for a block parameter (2 for 1) from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.0.2/lib/active_record/validations.rb:139
I have patched this issue with the following code:
error_collection.each {|error, message| markup << build_li.call([error, message])}
This patch is available as a pull on github at http://github.com/felttippin/mer...
git pull git://github.com/felttippin/merb-plugins.git
Comments and changes to this ticket
-
-
Matt Aimonetti April 30th, 2008 @ 08:25 AM
- → Title changed from “[PATCH] error collection warning: multiple values for a block parameter (2 for 1)” to “error collection warning: multiple values for a block parameter (2 for 1)”
just a quick comment, this was not a patch but a pull request.
To create a patch simply do:
git format-patch HEAD^(that will create one patch per commit you made)or
git format-patch --stdout origin > file_with_lots_of_commits-Matt
-
Michael Klishin (antares) May 2nd, 2008 @ 10:36 AM
- → Title changed from “error collection warning: multiple values for a block parameter (2 for 1)” to “[PULL] error collection warning: multiple values for a block parameter (2 for 1)”
- → Assigned user changed from “” to “Michael Klishin (antares)”
I will check it out as long as I can get rake spec running clean for me in merb_helpers.
-
Ezra Zygmuntowicz May 4th, 2008 @ 04:45 AM
- → State changed from “new” to “resolved”
this has already been applied as far as ai can tell.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Peter