[PATCH] [SPEC] Proc modifiers for select options
Reported by Jani Soila | July 8th, 2008 @ 03:10 PM | in 0.9.8
It is difficult to make non-trivial modifiers for select options with options_from_collection_for_select and current support for text_method and value_method options.
I added support for proc variables so that if text_method or value_method is kind of proc, then the output will be produced calling it with object. Also included a spec to test this functionality.
Comments and changes to this ticket
-
Jani Soila July 8th, 2008 @ 03:19 PM
- → Title changed from “[PATCH] Proc modifiers for select options” to “[PATCH] [SPEC] Proc modifiers for select options”
-
Michael Klishin (antares) August 2nd, 2008 @ 10:58 PM
- → Tag changed from “” to “form_helpers merb_helpers patch spec”
- → Milestone changed from “” to “1.0”
- → State changed from “new” to “open”
- → Assigned user changed from “” to “GMFlash”
-
Michael Klishin (antares) August 2nd, 2008 @ 11:05 PM
- → Milestone cleared.
-
Michael Klishin (antares) August 14th, 2008 @ 02:08 PM
- → Milestone changed from “” to “0.9.5”
-
Michael Klishin (antares) August 26th, 2008 @ 01:53 AM
- → Milestone changed from “0.9.5” to “0.9.6”
-
Michael Klishin (antares) September 4th, 2008 @ 06:59 AM
If you support Proc, why not support other callable objects? I'd recommend replacing kind_of?(Proc) all over the patch with respond_to?(:call), and please rebase this against HEAD from today.
Thanks.
-
Michael Klishin (antares) September 9th, 2008 @ 02:22 AM
- → Milestone changed from “0.9.6” to “0.9.7”
-
Michael Klishin (antares) September 14th, 2008 @ 02:07 AM
- → Milestone changed from “0.9.7” to “0.9.8”
- → State changed from “open” to “invalid”
This one hasn't seen any updates in a while, closing it.
-
Jani Soila September 23rd, 2008 @ 02:35 PM
- → Tag changed from “form_helpers merb_helpers patch spec” to “form_helpers merb_helpers patch spec”
Updated for the changes in form builder. Generalized to work with all callables. Sorry about slow reaction.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
