merb-plugins

Comments and changes to this ticket

• 

  Martin Kihlgren August 22nd, 2008 @ 06:10 PM

  • no changes were found...

  • spec_and_fix.patch 1.3 KB
• 

  Martin Kihlgren August 22nd, 2008 @ 06:10 PM

  • → Tag changed from “bug form_helpers merb-plugins merb_helpers spec” to “bug form_helpers merb-plugins merb_helpers patch spec”
  • → Title changed from “[spec] Merb::Helpers::Form::Builder::ResourcefulFormWithErrors does not work” to “[spec][patch] Merb::Helpers::Form::Builder::ResourcefulFormWithErrors does not work”

  Here is the same patch with the fix added. It was pretty trivial - just do @origin.url instead of #url.

• 

  Martin Kihlgren August 22nd, 2008 @ 06:13 PM

  • no changes were found...

  • 0002-Fixed-a-trivial-error-in-Resourceful.patch 1.7 KB
• 

  Martin Kihlgren August 22nd, 2008 @ 06:13 PM

  And here is the patch formatted as a proper git patch...

• 

  Bryan Ray August 23rd, 2008 @ 03:53 AM

  I've not been able to reproduce this error on the latest form helper refactor code located in wycats/origin/helper_refactors.

  Do you happen to have some "live" code that shows this error (outside of the patch spec)?

• 

  Martin Kihlgren August 25th, 2008 @ 10:22 AM

  Yes, I do, the project I am working on - but I feel that it is a bit unnecessary to send my entire project OR to create a new example of such a trivial bug.

  The lines ---------------------8<----------------------- Merb::BootLoader.after_app_loads do class Merb::Controller

  self._form_class =
    Object.full_const_get(Merb::Plugins.config[:helpers][:form_class]) rescue Merb::Helpers::Form::Builder::ResourcefulFormWithErrors
  

  end end -------------------8<------------------------- make Merb::Helpers::Form::Builder::ResourcefulFormWithErrors the default form class, and my spec just tries to see if it is possible to even use it at all. That ought to be enough, no?

• 

  Martin Kihlgren August 25th, 2008 @ 10:23 AM

  Oh ffs.

  I formatted the last message all weird. Here is a better formatted version:

  Yes, I do, the project I am working on - but I feel that it is a bit unnecessary to send my entire project OR to create a new example of such a trivial bug.

  The lines

  @@@ruby Merb::BootLoader.after_app_loads do class Merb::Controller

  self._form_class =
    Object.full_const_get(Merb::Plugins.config[:helpers][:form_class]) rescue Merb::Helpers::Form::Builder::ResourcefulFormWithErrors
  

  end end @@@ruby make Merb::Helpers::Form::Builder::ResourcefulFormWithErrors the default form class, and my spec just tries to see if it is possible to even use it at all. That ought to be enough, no?

• 

  Martin Kihlgren August 25th, 2008 @ 10:25 AM

  I strongly dislike that it is impossible to delete my comments in lighthouse :/

  One more try:

  Yes, I do, the project I am working on - but I feel that it is a bit unnecessary to send my entire project OR to create a new example of such a trivial bug.

  The lines

  @@@ruby Merb::BootLoader.after_app_loads do class Merb::Controller

  self._form_class =
    Object.full_const_get(Merb::Plugins.config[:helpers][:form_class]) rescue Merb::Helpers::Form::Builder::ResourcefulFormWithErrors
  

  end end

  
  make Merb::Helpers::Form::Builder::ResourcefulFormWithErrors the default form class, and my spec just tries to see if it is possible to even use it at all. That ought to be enough, no?
  

• 

  Martin Kihlgren August 25th, 2008 @ 10:26 AM

  Ok, I will try again. This is by god the last time.

  Yes, I do, the project I am working on - but I feel that it is a bit unnecessary to send my entire project OR to create a new example of such a trivial bug.

  The lines

  @@@javascript Merb::BootLoader.after_app_loads do class Merb::Controller

  self._form_class =
    Object.full_const_get(Merb::Plugins.config[:helpers][:form_class]) rescue Merb::Helpers::Form::Builder::ResourcefulFormWithErrors
  

  end end

  
  
  make Merb::Helpers::Form::Builder::ResourcefulFormWithErrors the default form class, and my spec just tries to see if it is possible to even use it at all. That ought to be enough, no?
  

• 

  Martin Kihlgren August 25th, 2008 @ 10:26 AM

  I give up. Lighthouse help page on formatting is most definitely lying :/

• 

  Michael Klishin (antares) August 29th, 2008 @ 12:18 PM

  • → Milestone changed from “” to “0.9.6”
  • → State changed from “new” to “open”
  • → Assigned user changed from “” to “GMFlash”
• 

  Yehuda Katz (wycats) September 2nd, 2008 @ 12:07 PM

  • → State changed from “open” to “resolved”